Review Request 119905: Parley: Fix bugs: 338302 and 338417 title bar [modified] tag behavior is inconsistent.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119905/#review65076
-----------------------------------------------------------


Still a name issue.  Otherwise OK.


src/parleymainwindow.cpp
<https://git.reviewboard.kde.org/r/119905/#comment45478>

    These names are really confusing, but that's not your fault, it's historical.  The parleyDocument and KEduVocDocument both being "document" in some cases makes it difficult to follow what is happening.
    
    But this name is even more confusing.  I still suggest documentChanged().  You are looking at the ParleyDocument from the outside, then it's irrelevant that there is an internal pointer to the KEduVocDocument. Ideally we whould have a signal from the ParleyDocument that it has changed, and skip the direct connection from the KEduVocDocument to the mainwindow.


- Inge Wallin


On Aug. 22, 2014, 7:55 p.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119905/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 7:55 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 338302 and 338417
>     http://bugs.kde.org/show_bug.cgi?id=338302
>     http://bugs.kde.org/show_bug.cgi?id=338417
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Symptoms:
> The [modified] in the title bar was inconsistent.
> 
> Problems:
> 1. The title bar was only connected to the dirty bit in the doc from the Editor.  Going directly welcome -> stats did not connect the title bar to the dirty bit.
> 2. Whenever a new document was created, new collection, welcome screen etc. the title bar was disconnected.
> 3. In several places setModified was called on the kvocdoc when either nothing changed or the kvocdoc should know better.
> 
> Solution:
> The title bar is ParleyMainWindow's title bar.  ParleyMainWindow also know when the document is updated.  I created a  updateParleyDocument so that ParleyMainWindow always knows when the doc changes and slotFileNew so that anyone can ask ParleyMainWindow to update its own title bar.
> 
> Not fixed: Parley still directly calls the setModified in kvocdoc when it starts practice.  kvocdoc needs to be fixed before that is removed.
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.cpp 4fac862 
>   src/parleydocument.cpp 0ebeca1 
>   src/parleymainwindow.h 98a94ad 
>   src/parleymainwindow.cpp 9723ee1 
>   src/practice/practicemainwindow.cpp 3008501 
>   src/settings/documentproperties.cpp 02cbf7b 
>   src/settings/languageproperties.cpp e9b171f 
>   src/vocabulary/vocabularymodel.cpp abf0db9 
>   src/welcomescreen/welcomescreen.cpp d24f444 
> 
> Diff: https://git.reviewboard.kde.org/r/119905/diff/
> 
> 
> Testing
> -------
> 
> Clicked from welcomescreen -> stats -> practice -> exit stats
> Clicked from welcomscreen -> stats -> editor (edited) -> practice
> Clicked from welcomscreen -> stats -> editor (no edit) -> practice
> Created a new collection from welcome screen
> Changed doc properties from stats->File->Properties.
> 
> All of these cases worked correctly
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140822/ac896401/attachment-0001.html>