Review Request 117636: Add importPackage menu to Sage backend in Cantor

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117636/#review57032
-----------------------------------------------------------

Ship it!


Looks good and works. Sorry for my late review. Please go ahead and commit!

- Alexander Rieder


On April 18, 2014, 8:55 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117636/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 8:55 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> This diff add SagePackagingExtension::importPackage to Sage backend, like in Python 2 backend. It enable a menu item in menu bar to import packages in Sage environment.
> 
> 
> Diffs
> -----
> 
>   src/backends/sage/sagebackend.cpp f5aed4c 
>   src/backends/sage/sageextensions.h b1a24ef 
>   src/backends/sage/sageextensions.cpp 9ced7ba 
> 
> Diff: https://git.reviewboard.kde.org/r/117636/diff/
> 
> 
> Testing
> -------
> 
> The diff compile without errors. You can test it importing any Python module using the menu.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140430/01c7655d/attachment.html>