Review Request 117816: Use marching cubes algorithm from Aqsis

Percy Camilo Triveño Aucahuasi percy.camilo.ta at gmail.com
Mon Apr 28 06:18:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117816/
-----------------------------------------------------------

Review request for KDE Edu.


Repository: analitza


Description
-------

Replace our marching cubes algorithm implementation for the one of Aqsis project. The Aqsis implementation is fastest and offers topological guarantees, in other words we'll have better surfaces as result (without missing faces, etc.)

Finally, we'll have less code to maintain :)


Diffs
-----

  analitzaplot/private/utils/octree.cpp 6106120 
  analitzaplot/private/utils/octree.h 1cf4b24 
  analitzaplot/private/utils/marchingcubes.cpp 49331f1 
  analitzaplot/private/utils/marchingcubes.h ef0b0c4 
  analitzaplot/private/utils/lookuptable.h PRE-CREATION 
  analitzaplot/private/backends/implicitsurface.cpp 68c7918 
  analitzaplot/CMakeLists.txt 9890449 

Diff: https://git.reviewboard.kde.org/r/117816/diff/


Testing
-------

Builds ok.
All analitzaplot tests pass.
Also, there is no licenses issues since the code is GPL >= 2 (same of Analitza)


Thanks,

Percy Camilo Triveño Aucahuasi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140428/84d34bb6/attachment-0001.html>


More information about the kde-edu mailing list