Review Request 116629: Parley plugin mwclient bug workaround: using standard urllib library for download instead of calling download() on wikiObject

Wed Apr 23 23:06:04 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116629/
-----------------------------------------------------------

(Updated April 23, 2014, 11:06 p.m.)

Review request for KDE Edu and Inge Wallin.

Changes
-------

Inge can you please review this? Maximilian did the mistake of giving himself a "Ship it" but still deserves a review :.)

Repository: parley

Description
-------

Parley plugin mwclient bug workaround: fetching content by calling wikiObject.download() raised a http 404 error, but urllib's open/read method works as expected on an existing URI.

Diffs
-----

  plugins/wiktionary/wiktionary_sound.py 92074bf 

Diff: https://git.reviewboard.kde.org/r/116629/diff/

Testing
-------

Using urlopen/read from the standard urllib library delivers object's content with http status 200 OK.

Thanks,

Maximilian Reiner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140423/346cd474/attachment.html>