Review Request 117512: Created empty KConfig XT to KAlgebra backend
Alexander Rieder
alexanderrieder at gmail.com
Wed Apr 16 21:27:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117512/#review55916
-----------------------------------------------------------
Ship it!
looks good to me. Unless Aleix has issues with it, i'd say go ahead and ship it!
- Alexander Rieder
On April 12, 2014, 2:16 p.m., Filipe Saraiva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117512/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 2:16 p.m.)
>
>
> Review request for KDE Edu and Alexander Rieder.
>
>
> Repository: cantor
>
>
> Description
> -------
>
> This patch create an empty KConfig XT to KAlgebra backend.
> It will be used to create autorun script support in KAlgebra backend.
>
>
> Diffs
> -----
>
> src/backends/kalgebra/CMakeLists.txt afcd6f9
> src/backends/kalgebra/kalgebrabackend.h c63c646
> src/backends/kalgebra/kalgebrabackend.cpp af3febc
> src/backends/kalgebra/kalgebrabackend.kcfg PRE-CREATION
> src/backends/kalgebra/settings.kcfgc PRE-CREATION
> src/backends/kalgebra/settings.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117512/diff/
>
>
> Testing
> -------
>
> It just compile without errors.
>
>
> Thanks,
>
> Filipe Saraiva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140416/fb2f4f75/attachment.html>
More information about the kde-edu
mailing list