Review Request 117364: Implement dual-direction training, a.k.a. mixed mode training

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117364/
-----------------------------------------------------------

(Updated April 6, 2014, 9:13 a.m.)


Review request for KDE Edu and Amarvir Singh.


Changes
-------

Here is version 2.  Everything is fixed, except:
 - Big FIXME in the main window (setting fonts)
 - Visual problem with the conjugation widget.

The first one I will fix before the final version and the second I am actually willing to skip for now because we are entering a process with a real graphic designer so it will be much different before the release anyway.

In particular I fixed our naming problem by calling the new concept "Training Direction".  Take a look.

This time, it's much closer to merging so I could use some more detailed comments on the code.


Repository: parley


Description
-------

This patch implementes dual-direction training, which we have also called mixed mode training. The patch is not ready for merging yet but I want feedback on the solution and there are some things to discuss.

Visually, the patch removes the language selection listbox and instead adds two selectors: "known language" (the user should select the native language if possible) and "language to learn". In addition to that there is also a new mode selector for the type of practice that the user wants: known-to-learning, learning-to-known our dual direction / mixed mode.  

In the future I will also implement sound-only to known, which trains the ability to understand spoken language, which is not the same as reading. But I cannot do that yet since the kvtml format doesn't support enough ways to keep the training status (grades).

For this review, I would prefer higher-level comments. I will find all trailing spaces and undone FIXME's myself and fix them before the next time around.

So, the questions then:

1. What shall we call the setting for the new mode in the settings file? Right now I call it TrainingMode2 which we obviously need to change.

2. How can we improve the visual layout of the training settings? The new mode selector is separated from the other settings by a qwidget which keeps conjugation settings. But this widget is only visible when the conjugation training mode is chosen.  Perhaps we can make the widget not shown when other modes are active?  Or shall we move the new mode setting somewhere else?

Feedback is most welcome.


Diffs (updated)
-----

  TODO-MIXEDMODE PRE-CREATION 
  src/CMakeLists.txt fb29bc6 
  src/parleymainwindow.cpp 74ff823 
  src/practice/CLASSES 941f801 
  src/practice/abstractbackendmode.h 10e9162 
  src/practice/abstractbackendmode.cpp 9a08575 
  src/practice/comparisonbackendmode.h deeeb28 
  src/practice/comparisonbackendmode.cpp 2bc1c50 
  src/practice/conjugationbackendmode.h 91da66d 
  src/practice/conjugationbackendmode.cpp 749fb33 
  src/practice/entryfilter.h c1fd843 
  src/practice/entryfilter.cpp 7a0e759 
  src/practice/examplesentencebackendmode.h 10d9e72 
  src/practice/examplesentencebackendmode.cpp 1caa3f6 
  src/practice/flashcardbackendmode.h 32f43d2 
  src/practice/flashcardbackendmode.cpp dc0e8e6 
  src/practice/genderbackendmode.h bf0bf47 
  src/practice/genderbackendmode.cpp 997f400 
  src/practice/multiplechoicebackendmode.h 5ee9249 
  src/practice/multiplechoicebackendmode.cpp e2c5132 
  src/practice/practicemainwindow.cpp 9be490e 
  src/practice/practiceoptions.h b5a1cf7 
  src/practice/practiceoptions.cpp e7ff9aa 
  src/practice/practicestatemachine.h e1dbc5c 
  src/practice/practicestatemachine.cpp 8ae77b5 
  src/practice/practicesummarycomponent.cpp bca5b94 
  src/practice/sessionmanagerbase.h 8066279 
  src/practice/sessionmanagerbase.cpp 69a1a7d 
  src/practice/sessionmanagerfixed.cpp 18a11a3 
  src/practice/testentry.h e779075 
  src/practice/testentry.cpp 9f6b8db 
  src/practice/writtenbackendmode.h 86138be 
  src/practice/writtenbackendmode.cpp 2b3bc9b 
  src/settings/parley.kcfg c831b13 
  src/statistics/statisticsmainwindow.h 9cbce05 
  src/statistics/statisticsmainwindow.cpp 24d23bf 
  src/statistics/statisticsmainwindow.ui 2426fd7 

Diff: https://git.reviewboard.kde.org/r/117364/diff/


Testing
-------

Tested with flashcards.  More testing is also very welcome, especially by people who know how conjugation, comparition and gender training works.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140406/758ce151/attachment.html>