Review Request 112460: Label all lines in Sky Calendar

Vijay Dhameliya vijay.atwork13 at gmail.com
Sun Sep 29 06:23:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112460/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 6:23 a.m.)


Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.


Description
-------

Issue: Label are appearing only on graph of rise, set and transit time vs days in night time region i.e. some lines still don't get labelled.

Solved: Label will appear on each separated line object in graph and some time label is there on graph but it has gone outside so can be seen by hovering over starting or ending point of line. 


Diffs
-----

  kstars/skyobjects/skypoint.cpp f634075 
  kstars/tools/skycalendar.cpp 3ca61de 

Diff: http://git.reviewboard.kde.org/r/112460/diff/


Testing
-------

Tested and works fine


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_After.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Venus_Kolkata_Before.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_After.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/Neptune_Klamath_Fall_Before.png


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130929/55e26e00/attachment-0001.html>


More information about the kde-edu mailing list