Review Request 112898: Setting alt/az from ra/dec for constellation object while loading data and solve bug 325198

Vijay Dhameliya vijay.atwork13 at gmail.com
Sun Sep 29 06:20:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112898/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 6:20 a.m.)


Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.


Description
-------

While loading data from file, only ra/dec for constellation object are set which leads in error when alt/az of constellation objects are used without call to SkyPoint:EquatorialToHorizontal() (attached bug is one example). To avoid such scenario alt/az of constellation object are set while loading it to ConstellationNamesComponent.


This addresses bug 325198.
    http://bugs.kde.org/show_bug.cgi?id=325198


Diffs
-----

  kstars/skycomponents/constellationnamescomponent.cpp 0b43633 

Diff: http://git.reviewboard.kde.org/r/112898/diff/


Testing
-------

Tested


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130929/3f7121dd/attachment.html>


More information about the kde-edu mailing list