Review Request 112285: Adopt Google images to the new Google images search page

Commit Hook null at kde.org
Thu Sep 26 18:27:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112285/#review40890
-----------------------------------------------------------


This review has been submitted with commit a5ac48d6e8518c1c10f5e2010c59ed73147cc2f4 by Yuri Chornoivan to branch KDE/4.11.

- Commit Hook


On Sept. 26, 2013, 6:26 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112285/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 6:26 p.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Google has changed images search result page so now thumbnails are embedded into the page code itself as binary data. This leads to Parley's Google image plugin cannot file any images.
> 
> The patch tries to change parsing strategy to obtain the address of the original image and download this image instead of the thumbnail from the search page.
> 
> 
> Diffs
> -----
> 
>   plugins/google_images.py 5317ba6 
> 
> Diff: http://git.reviewboard.kde.org/r/112285/diff/
> 
> 
> Testing
> -------
> 
> Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download an average image from Wikipedia. All images are of good quality, everything seems to work as expected.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130926/d0114fc4/attachment-0001.html>


More information about the kde-edu mailing list