Review Request 112285: Adopt Google images to the new Google images search page

[Yuri Chornoivan]

> On Sept. 25, 2013, 8:46 p.m., Albert Astals Cid wrote:
> > The code looks reasonable, so for me, you can ship it.
> > 
> > If you prefer someone else to try it to make sure it works on two people computers, you'll have to tell me what to do, since i'm not able to find how to invoke the script :D

Sure, the aim was to subject it to a wider testing.

The procedure to invoke the script is as follows:

1. Choose "Create a New Collection" on the starting page of Parley.

2. Choose the first language "English" and the second language "Catalan" (just in this example).

3. Push "OK" twice.

4. Enter "potato" in the first field on the lesson editor pane for English and "patata" for Catalan.

5. Use "File -> Save" to save the file somewhere.

6. Choose "Scripts -> Script Manager" from the menu.

7. Untick (or tick) the checkbox for "Example Parley Script", push "OK".

8. Select "potato" in the list.

9. Choose "Scripts -> Fetch Image".

Many thanks for testing the patch.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112285/#review40817
-----------------------------------------------------------


On Aug. 26, 2013, 12:24 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112285/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 12:24 p.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Google has changed images search result page so now thumbnails are embedded into the page code itself as binary data. This leads to Parley's Google image plugin cannot file any images.
> 
> The patch tries to change parsing strategy to obtain the address of the original image and download this image instead of the thumbnail from the search page.
> 
> 
> Diffs
> -----
> 
>   plugins/google_images.py 5317ba6 
> 
> Diff: http://git.reviewboard.kde.org/r/112285/diff/
> 
> 
> Testing
> -------
> 
> Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download an average image from Wikipedia. All images are of good quality, everything seems to work as expected.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130926/c494e958/attachment.html>