Review Request 113502: Fix for Bug 326722 - swapped title and error message

Vincenzo Pii vinc.pii at gmail.com
Wed Oct 30 06:55:16 UTC 2013



> On Oct. 29, 2013, 11:38 p.m., Aleix Pol Gonzalez wrote:
> > Ship It!

Guys, I cannot ship because I don't have w access on the repo!
I just applied for a dev access on KDE Identity.
Instruct me if I have to do otherwise.


- Vincenzo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113502/#review42677
-----------------------------------------------------------


On Oct. 29, 2013, 9:03 p.m., Vincenzo Pii wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113502/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 9:03 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Related bug: https://bugs.kde.org/show_bug.cgi?id=326722
> Implementation: KMessageBox::error method arguments were misplaced, just swapped them to get the correct behavior.
> 
> 
> Diffs
> -----
> 
>   src/tools/moleculeview.cpp 930fb6a 
> 
> Diff: http://git.reviewboard.kde.org/r/113502/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vincenzo Pii
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131030/2b4c1f6c/attachment-0001.html>


More information about the kde-edu mailing list