Review Request 113499: Plugins based on mwclient broken

[Jeremy Whiting]

> On Oct. 29, 2013, 11:45 a.m., Jeremy Whiting wrote:
> > One question, can we just make parley use libmediawiki rather than keep a copy of it in parley's source tree?
> 
> Aleix Pol Gonzalez wrote:
>     Well, that would add a dependency to mwclient. I don't have mediawiki from archlinux, apparently debian doesn't have it either... And in general, I'd say it can be updated for 4.11 and remove it for 4.13 with a better solution.

Yep, sounds good, may want to add a TODO in there so it doesn't get forgotten. But this is good for 4.12 for sure.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113499/#review42648
-----------------------------------------------------------


On Oct. 29, 2013, 11:17 a.m., José Manuel  Santamaría Lema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113499/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 11:17 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 214263
>     http://bugs.kde.org/show_bug.cgi?id=214263
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Hi, since some time ago the plugins based on mediawiki doesn't work. I tend to think this happens because of a bug in the embedded copy of mwclient, so I have just updated it to the latest version and now the plugins to acquire images and sounds work. In addition to copy the files, I also had to update the file plugins/wiktionary/CMakeLists.txt in order to get some new files from mwclient installed.
> 
> Caveat: if you are going to test the patch you may hit this other bug: https://bugs.kde.org/show_bug.cgi?id=326798
> 
> 
> Diffs
> -----
> 
>   plugins/wiktionary/mwclient/REFERENCE.txt 983df50 
>   plugins/wiktionary/mwclient/README.txt ff14892 
>   plugins/wiktionary/CMakeLists.txt 860ec65 
>   plugins/wiktionary/mwclient/RELEASE-NOTES.txt PRE-CREATION 
>   plugins/wiktionary/mwclient/__init__.py 3ac2b76 
>   plugins/wiktionary/mwclient/client.py 3eb6d82 
>   plugins/wiktionary/mwclient/compatibility.py 69ee4fc 
>   plugins/wiktionary/mwclient/errors.py 297e6b9 
>   plugins/wiktionary/mwclient/ex.py afb77d9 
>   plugins/wiktionary/mwclient/http.py d9ca695 
>   plugins/wiktionary/mwclient/listing.py a9a50b4 
>   plugins/wiktionary/mwclient/page.py f7ba897 
>   plugins/wiktionary/mwclient/page_nowriteapi.py 109dccf 
>   plugins/wiktionary/mwclient/simplejson/__init__.py 7738592 
>   plugins/wiktionary/mwclient/simplejson/_speedups.c 8f290bb 
>   plugins/wiktionary/mwclient/simplejson/decoder.py a1b53b2 
>   plugins/wiktionary/mwclient/simplejson/encoder.py eec9c7f 
>   plugins/wiktionary/mwclient/simplejson/ordered_dict.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/scanner.py 64f4999 
>   plugins/wiktionary/mwclient/simplejson/tests/__init__.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_check_circular.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_decimal.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_decode.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_default.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_dump.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_encode_basestring_ascii.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_encode_for_html.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_errors.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_fail.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_float.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_indent.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_pass1.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_pass2.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_pass3.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_recursion.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_scanstring.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_separators.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_speedups.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tests/test_unicode.py PRE-CREATION 
>   plugins/wiktionary/mwclient/simplejson/tool.py PRE-CREATION 
>   plugins/wiktionary/mwclient/upload.py PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113499/diff/
> 
> 
> Testing
> -------
> 
> In the vocabulary editor I have just tried the plugins to fetch sounds and images. It seems they work again.
> 
> 
> Thanks,
> 
> José Manuel  Santamaría Lema
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131029/4d1771ca/attachment-0001.html>