Review Request 113490: Don't crash when exporting to HTML
José Manuel Santamaría Lema
panfaust at gmail.com
Tue Oct 29 10:19:37 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113490/
-----------------------------------------------------------
(Updated Oct. 29, 2013, 10:19 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Bugs: 238022
http://bugs.kde.org/show_bug.cgi?id=238022
Repository: parley
Description
-------
I think everything is already explained in this comment:
https://bugs.kde.org/show_bug.cgi?id=238022#c1
Let me know if you need more information.
Diffs
-----
src/export/exportdialog.cpp e40792a
Diff: http://git.reviewboard.kde.org/r/113490/diff/
Testing
-------
I tried to export a vocabulary file to a place where I don't have permissions (/boot/); with the patch instead of crashing shows an error message. Also I did a legit export to HTML and it seems the patch doesn't break anything for me.
Thanks,
José Manuel Santamaría Lema
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131029/ee0fd017/attachment.html>
More information about the kde-edu
mailing list