Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.

[Jaime Torres Amate]

> On Oct. 28, 2013, 11:21 p.m., Albert Astals Cid wrote:
> > src/placeasker.cpp, line 109
> > <http://git.reviewboard.kde.org/r/113425/diff/3-4/?file=205881#file205881line109>
> >
> >     Why this change?

I changed the way to calculate the distance from using the middle point of the division rect and the mouse click to the top left division rect and top left image click.
Why? Because looking at the points reported when clicking a zoomed map, the distance (even clicking in the right place) where >20. When I changed to the top left image position and top left position, they matched.
The problem is that the image size is (-1,-1) smaller than the division rect, therefore the centers where distancting as I zoomed the map.
This problem is not present with the top left corners.


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review42564
-----------------------------------------------------------


On Oct. 28, 2013, 5:41 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 5:41 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 285330
>     http://bugs.kde.org/show_bug.cgi?id=285330
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... Just handling all the view events to move the division smoothly.
> This time, just paint the background white and then draw the map without divisions (before the first division is asked), then add the divisions as they are asked.
> (as always, the red spaces will be gone). The variable "punto" will be translated.
> 
> 
> Diffs
> -----
> 
>   src/placeasker.h 14dce46 
>   src/placeasker.cpp 07bea6c 
>   src/placemapwidget.h 6905a14 
>   src/placemapwidget.cpp 94a4460 
> 
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
> 
> 
> Testing
> -------
> 
> Zoom, move (it behaves like before), with several maps in two computers (one that was not affected by the bug and one that was affected).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131029/3b48922a/attachment.html>