Review Request 113491: Ask before overwirting files when exporting to HTML

Jeremy Whiting jpwhiting at kde.org
Mon Oct 28 21:05:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113491/#review42559
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 28, 2013, 2:45 p.m., José Manuel  Santamaría Lema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113491/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 2:45 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Hi,
> 
> I have just found that when you export to HTML parley doesn't ask if you want to overwrite the file in case you already had a file with the same name. So I'm posting a porposed patch with this review request to fix the problem.
> 
> 
> Diffs
> -----
> 
>   src/export/exportdialog.cpp e40792a 
> 
> Diff: http://git.reviewboard.kde.org/r/113491/diff/
> 
> 
> Testing
> -------
> 
> Exported a file with and without overwriting it; it seems the patch works for me.
> 
> 
> Thanks,
> 
> José Manuel  Santamaría Lema
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131028/1ad8b2e7/attachment.html>


More information about the kde-edu mailing list