Review Request 111121: analitza fails to compile armhf due to qreal (float) and gldouble (double) type differences

Aleix Pol Gonzalez aleixpol at kde.org
Fri Oct 25 19:05:12 UTC 2013



> On Sept. 25, 2013, 8:27 p.m., Albert Astals Cid wrote:
> > Aleix, Maximiliano, what's the status of this? What do you need to get this merged? Been a while since the last comment and seems it should not be "a very difficult patch" to get in (speaking from the "I know nothing" side :D)

Well, on Qt5 QMatrix is using float anyway, so I'd say the best is to adopt the change a bit earlier.

Can you make a patch to change it to GLfloat matrix[16]?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111121/#review40808
-----------------------------------------------------------


On June 19, 2013, 3:33 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111121/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 3:33 p.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Bugs: 321244
>     http://bugs.kde.org/show_bug.cgi?id=321244
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   analitzaplot/plotter3d.cpp 492a84c87558ce85722b0d26727f264a6d914e4c 
> 
> Diff: http://git.reviewboard.kde.org/r/111121/diff/
> 
> 
> Testing
> -------
> 
> .
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131025/02bb7059/attachment.html>


More information about the kde-edu mailing list