Review Request 113249: make the popups move with the scrollbars and do not show 1 or 2 pixels between the scrollbars and the window decoration

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113249/#review41846
-----------------------------------------------------------

Ship it!


Looks good :-)

- Albert Astals Cid


On Oct. 14, 2013, 6:11 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113249/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 6:11 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> I wanted the popups to move with the map when the scrollbars are used. I tried the hard way (trying to handle the scrollbars events....., but it was much, much simpler that I thought).
> As a side effect, the popups now do not show 1 or 2 pixels between the scrollbars and the window decoration.
> The popup will disappear as before (except when the scrollbars are moved).
> 
> 
> Diffs
> -----
> 
>   src/mapasker.cpp 30ddd91 
> 
> Diff: http://git.reviewboard.kde.org/r/113249/diff/
> 
> 
> Testing
> -------
> 
> I've been using it without problems for 1 week.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131016/1f1fb2cb/attachment.html>