Review Request 112726: Ordered visibility check for first point of SkyPolyLine in drawSkyPolyline function

[Albert Astals Cid]

> On Sept. 29, 2013, 10:21 p.m., Henry de Valence wrote:
> > This looks OK to me.

Henry, Vijay doesn't have a commiter account, do you plan to commit it or want me to do it for you?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112726/#review41012
-----------------------------------------------------------


On Sept. 29, 2013, 6:27 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112726/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 6:27 a.m.)
> 
> 
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Bugs: 303547
>     http://bugs.kde.org/show_bug.cgi?id=303547
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Variable isVisibleLast and isVisible are not initialized so stores random value while operated and with check visibility and correct visibility of point are stored in same variable when passed to toScreen function.  
> 
> 
> Diffs
> -----
> 
>   kstars/skyqpainter.cpp b53b76c 
> 
> Diff: http://git.reviewboard.kde.org/r/112726/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> Lines on display appears correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131013/f896c944/attachment.html>