Review Request 113817: Default Syntax Highlighting in Cantor Script Extension Widget

[Filipe Saraiva]

On Nov. 13, 2013, 5:14 p.m., Filipe Saraiva wrote:
> > I think "languageHighlighting" is not the best term to use. In my opinion it would be better to use highlightingLanguage. (or maybe just reuse HighlightingMode from KTextEditor? ). Other than that, code wise the change looks fine.
> 
> Filipe Saraiva wrote:
>     Thanks Alex, I will change the function name to "highlightingMode" (I think it is more interesting) and will push the code tonight.

Pushed http://quickgit.kde.org/?p=cantor.git&a=commitdiff&h=d35e48aa4093ea7e2b9e08146aab0335aad14adb&hp=c9e7a76ce5a3fef6df90c88acd522cdbb0b3f177
Thank you Alex!


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113817/#review43615
-----------------------------------------------------------


On Nov. 12, 2013, 1:39 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113817/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 1:39 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> In currently Cantor version, the user must choose the syntax highlighting changing the option in a kpart menu - it is hide from user.
> This patch allow syntax highlighting in script extension when the script widget is launched by user.
> 
> I ported Octave, Sage, R, and Maxima backends to support it too.
> 
> 
> Diffs
> -----
> 
>   src/backends/octave/octaveextensions.cpp 534e69e 
>   src/backends/sage/sageextensions.h 5022c69 
>   src/backends/sage/sageextensions.cpp 9efc856 
>   src/cantor_part.cpp 7aad304 
>   src/lib/extension.h 3c5085d 
>   src/scripteditorwidget.h 2ca672d 
>   src/scripteditorwidget.cpp 03684aa 
>   src/backends/R/rextensions.h 39d5f1b 
>   src/backends/R/rextensions.cpp a036220 
>   src/backends/maxima/maximaextensions.h 34afc2a 
>   src/backends/maxima/maximaextensions.cpp 211c8cb 
>   src/backends/octave/octaveextensions.h 5dae826 
> 
> Diff: http://git.reviewboard.kde.org/r/113817/diff/
> 
> 
> Testing
> -------
> 
> Tested with Octave, Sage, R, and Maxima backends.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131114/832716e8/attachment-0001.html>