Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.

Commit Hook null at kde.org
Tue Nov 12 19:56:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review43546
-----------------------------------------------------------


This review has been submitted with commit cb4705ac1ed8cf205fd9ddbbad86a093b85ce9a8 by Jaime Torres to branch master.

- Commit Hook


On Nov. 12, 2013, 7:55 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 7:55 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 285330
>     http://bugs.kde.org/show_bug.cgi?id=285330
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... Just handling all the view events to move the division smoothly.
> This time, just paint the background white and then draw the map without divisions (before the first division is asked), then add the divisions as they are asked.
> (as always, the red spaces will be gone). The variable "punto" will be translated.
> 
> 
> Diffs
> -----
> 
>   src/placeasker.h 14dce46 
>   src/placeasker.cpp dd2f02c 
>   src/placemapwidget.h 6905a14 
>   src/placemapwidget.cpp 94a4460 
> 
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
> 
> 
> Testing
> -------
> 
> Zoom, move (it behaves like before), with several maps in two computers (one that was not affected by the bug and one that was affected).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131112/e39e857e/attachment.html>


More information about the kde-edu mailing list