Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review43472
-----------------------------------------------------------

Ship it!


Looks good. The question now is, where do we commit this one. It is a "big-ish" change, so one would think master, but on the other hand it fixes a bug some people is having so someone else would say KDE/4.11. 

I'm a bit undecided so i'd go for the middle way and go KDE/4.12.

What's your opinion?

- Albert Astals Cid


On Nov. 10, 2013, 11:41 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 11:41 a.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 285330
>     http://bugs.kde.org/show_bug.cgi?id=285330
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... Just handling all the view events to move the division smoothly.
> This time, just paint the background white and then draw the map without divisions (before the first division is asked), then add the divisions as they are asked.
> (as always, the red spaces will be gone). The variable "punto" will be translated.
> 
> 
> Diffs
> -----
> 
>   src/placeasker.h 14dce46 
>   src/placeasker.cpp dd2f02c 
>   src/placemapwidget.h 6905a14 
>   src/placemapwidget.cpp 94a4460 
> 
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
> 
> 
> Testing
> -------
> 
> Zoom, move (it behaves like before), with several maps in two computers (one that was not affected by the bug and one that was affected).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131111/b7d4bc51/attachment.html>