Review Request 113660: filter the list of maps

Albert Astals Cid aacid at kde.org
Mon Nov 11 21:50:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113660/#review43468
-----------------------------------------------------------

Ship it!


Good!

- Albert Astals Cid


On Nov. 11, 2013, 5:19 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113660/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 5:19 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 319974
>     http://bugs.kde.org/show_bug.cgi?id=319974
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Change from QListWidget to QListView because QListWidget setModel() is private :-(
> Implemented an eventFilter to make QListView behave like a QListWidget.
> Implemented a filterProxyModel to filter the list (by the first letters).
> 
> Is the text inside the KLineEdit right?
> Should it filter by first letters or any letter?
> 
> 
> Diffs
> -----
> 
>   src/mapchooser.cpp c2bf8ec 
> 
> Diff: http://git.reviewboard.kde.org/r/113660/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131111/b4a92969/attachment.html>


More information about the kde-edu mailing list