Review Request 113660: filter the list of maps

Jaime Torres Amate jtamate at gmail.com
Sun Nov 10 09:52:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113660/
-----------------------------------------------------------

(Updated Nov. 10, 2013, 9:52 a.m.)


Review request for KDE Edu and Albert Astals Cid.


Changes
-------

Much, much easier using this KDE class I didn't knew before.
Now I've copied the offline KDE api documentation to not work again more than enough in the place I have to stay (almost isolated) to get paid. 


Bugs: 319974
    http://bugs.kde.org/show_bug.cgi?id=319974


Repository: kgeography


Description
-------

Change from QListWidget to QListView because QListWidget setModel() is private :-(
Implemented an eventFilter to make QListView behave like a QListWidget.
Implemented a filterProxyModel to filter the list (by the first letters).

Is the text inside the KLineEdit right?
Should it filter by first letters or any letter?


Diffs (updated)
-----

  src/mapchooser.h 138b322 
  src/mapchooser.cpp c2bf8ec 

Diff: http://git.reviewboard.kde.org/r/113660/diff/


Testing
-------


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131110/2be4441d/attachment.html>


More information about the kde-edu mailing list