Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.

[Jaime Torres Amate]

> On Oct. 30, 2013, 11:10 p.m., Albert Astals Cid wrote:
> > Another graphical issue:
> >  * Zoom in quite a bit
> >  * Make sure your window is not maximized
> >  * Press middle mouse button and don't release until it's outside of the window
> >  * Release the middle mouse button
> >  * See how the division you where supposed to put in the map is left there floating
> >  * Sometimes when entering the window again the old one is cleaned but some other times you end up with two items (the ghost one is cleaned if you pass the new one over)
> 
> Jaime Torres Amate wrote:
>     I can not reproduce in a vbox or with an ati card. (I guess you have an nvidia card).
>     Could you try using this code in placeMapWidget::placeMapWidget constructor?
>     
>     	setScene(p_scene);
>     	p_scene->setItemIndexMethod(QGraphicsScene::NoIndex);
>     	setViewportUpdateMode(QGraphicsView::FullViewportUpdate);
>     }
>
> 
> Albert Astals Cid wrote:
>     Intel here. That does indeed seem to fix the glitchs, or at least i can't reproduce them anymore, i'm thinking on the other hand how hard would it be to not remove the item from the view when we move the mouse out of it. Do you think it makes sense and/or is possible code-wise?

I do not remove the item when the mouse is out...it is just not displayed (outside of the viewport). The item is created and hidden/shown depending on the zoom status, but never deleted (until the scene is deleted at the end of the question session).


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review42725
-----------------------------------------------------------


On Oct. 28, 2013, 5:41 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 5:41 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 285330
>     http://bugs.kde.org/show_bug.cgi?id=285330
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... Just handling all the view events to move the division smoothly.
> This time, just paint the background white and then draw the map without divisions (before the first division is asked), then add the divisions as they are asked.
> (as always, the red spaces will be gone). The variable "punto" will be translated.
> 
> 
> Diffs
> -----
> 
>   src/placeasker.h 14dce46 
>   src/placeasker.cpp 07bea6c 
>   src/placemapwidget.h 6905a14 
>   src/placemapwidget.cpp 94a4460 
> 
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
> 
> 
> Testing
> -------
> 
> Zoom, move (it behaves like before), with several maps in two computers (one that was not affected by the bug and one that was affected).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131103/60c381ba/attachment.html>