Review Request 110617: Implemented Open Action for Khipu

Punit Mehta punit9461 at gmail.com
Thu May 30 14:40:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110617/
-----------------------------------------------------------

(Updated May 30, 2013, 2:40 p.m.)


Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.


Changes
-------

Removed the space description when we want to open a file .! 


Description
-------

The diff contains the implementation of the open action in Khipu.! The attached parent diff is for the save action which is already reviewed.! 
If the user saves the plotspaces in .khipu file and then  he can open the file when he wants.! The initial implementation is done in a way that it considers the case only when on work is done ( i.e the user has just opened the application and then in the very next step , he is going to open his previously saved .khipu file.! I am working for dealing with the other cases also..! 

- I have added the entry of plot-colot in the .khipu file as we are requesting and creating the plots when the plotspace-thumbnail is doubleclicked.! So , we need that information also.!


Diffs (updated)
-----

  CMakeLists.txt f7dc583 
  src/CMakeLists.txt 0a50c54 
  src/dashboard.h a2a9c46 
  src/dashboard.cpp 688a49d 
  src/datastore.h a1276a7 
  src/datastore.cpp 616e0cc 
  src/mainwindow.h 1f059f8 
  src/mainwindow.cpp 9d6e010 
  src/plotseditor.h 47304c6 
  src/plotseditor.cpp 106cdf5 

Diff: http://git.reviewboard.kde.org/r/110617/diff/


Testing
-------

Done.! as mentioned , it works very well for the specified case.!


Thanks,

Punit Mehta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130530/b46487f7/attachment.html>


More information about the kde-edu mailing list