Review Request 110617: Implemented Open Action for Khipu

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110617/#review33047
-----------------------------------------------------------



src/dashboard.cpp
<http://git.reviewboard.kde.org/r/110617/#comment24440>

    you never clear after constructing, it doesn't make sense



src/dashboard.cpp
<http://git.reviewboard.kde.org/r/110617/#comment24439>

    This openclicked variable should go. It's ugly and I don't see why you need it.



src/mainwindow.h
<http://git.reviewboard.kde.org/r/110617/#comment24443>

    You probably want to give a better name to this variable.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110617/#comment24442>

    It probably doesn't make sensse to try to compress a png file. PNG already compresses.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110617/#comment24441>

    you're passing compressedImage to array and then back to QString. It's odd.
    
    Just use QByteArray::fromBase64 and ::toBase64.


- Aleix Pol Gonzalez


On May 23, 2013, 2:07 p.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110617/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 2:07 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> The diff contains the implementation of the open action in Khipu.! The attached parent diff is for the save action which is already reviewed.! 
> If the user saves the plotspaces in .khipu file and then  he can open the file when he wants.! The initial implementation is done in a way that it considers the case only when on work is done ( i.e the user has just opened the application and then in the very next step , he is going to open his previously saved .khipu file.! I am working for dealing with the other cases also..! 
> 
> - I have added the entry of plot-colot in the .khipu file as we are requesting and creating the plots when the plotspace-thumbnail is doubleclicked.! So , we need that information also.!
> 
> 
> Diffs
> -----
> 
>   src/dashboard.h a2a9c46 
>   src/dashboard.cpp 688a49d 
>   src/mainwindow.h 1f059f8 
>   src/mainwindow.cpp 9d6e010 
> 
> Diff: http://git.reviewboard.kde.org/r/110617/diff/
> 
> 
> Testing
> -------
> 
> Done.! as mentioned , it works very well for the specified case.!
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130524/8d10a3f8/attachment.html>