Review Request 110414: Implemented Save Action in Khipu

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110414/#review32791
-----------------------------------------------------------



src/mainwindow.h
<http://git.reviewboard.kde.org/r/110414/#comment24350>

    indentation
    



src/mainwindow.h
<http://git.reviewboard.kde.org/r/110414/#comment24351>

    better pass a "const QPixmap&". It's how it's usually done in Qt, with non-QObject classes



src/plotseditor.h
<http://git.reviewboard.kde.org/r/110414/#comment24352>

    I don't think you really want to expose that.


This change is too complex for its purpose. Why don't you add signals for doing this, instead of keeping track of the saved spaces (m_savedSpaces)? It's very likely it will end up breaking eventually.

- Aleix Pol Gonzalez


On May 18, 2013, 11:19 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110414/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 11:19 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f7dc583 
>   src/CMakeLists.txt 0a50c54 
>   src/datastore.h a1276a7 
>   src/datastore.cpp 616e0cc 
>   src/mainwindow.h 1f059f8 
>   src/mainwindow.cpp 9d6e010 
>   src/plotseditor.h 47304c6 
>   src/plotseditor.cpp 106cdf5 
> 
> Diff: http://git.reviewboard.kde.org/r/110414/diff/
> 
> 
> Testing
> -------
> 
> Done..! worked perfect for any situtation I have come across. !
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130519/085350d5/attachment.html>