Review Request 110379: Make sure a full path is saved for images and sound if the vocabulary has not been previously written to disk.

[Peter Hedlund]

> On May 13, 2013, 10:16 p.m., Albert Astals Cid wrote:
> > This looks a bit fragile, what if i actually name my file "Untitled"? There's no internal way of knowing if the file has been saved?

We currently have no other way than looking for "Untitled". I will however soon update the patch as it does not address a similar issue occurring if the user does "Save As..." in a different folder.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110379/#review32459
-----------------------------------------------------------


On May 10, 2013, 1:45 a.m., Peter Hedlund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110379/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 1:45 a.m.)
> 
> 
> Review request for KDE Edu, Frederik Gladhorn, Peter Hedlund, and Jeremy Paul Whiting.
> 
> 
> Description
> -------
> 
> Make sure a full path is saved for images and sound if the vocabulary has not been previously written to disk.
> 
> 
> This addresses bug 318787.
>     http://bugs.kde.org/show_bug.cgi?id=318787
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvockvtml2writer.cpp 99ad94d 
> 
> Diff: http://git.reviewboard.kde.org/r/110379/diff/
> 
> 
> Testing
> -------
> 
> Tested with KWordQuiz and Parley. Linking images (and sounds) now work as expected.
> 
> 
> Thanks,
> 
> Peter Hedlund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130513/ceed10c7/attachment-0001.html>