Review Request 110414: Implemented Save Action in Khipu

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110414/#review32445
-----------------------------------------------------------



src/mainwindow.h
<http://git.reviewboard.kde.org/r/110414/#comment24126>

    You don't initialize members here. = 0 goes to the constructor.
    
    Also do we really ned these attributes?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110414/#comment24125>

    Unrelated to this patch. Also I'm unsure we want that.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110414/#comment24124>

    You should _never_ use exit(0).
    
    I'm unsure what you're trying to do anyway.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110414/#comment24123>

    We have API for painting the contents of 2D and 3D graphs into an image. Maybe you should use that.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/110414/#comment24121>

    Use QByteArray, not QString.
    
    Also fix indentation



src/plotseditor.cpp
<http://git.reviewboard.kde.org/r/110414/#comment24122>

    This looks like terrible API. If you want to do this I'd suggest calling it addPlot and calling plotsModel() from within.


- Aleix Pol Gonzalez


On May 13, 2013, 1:55 p.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110414/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 1:55 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f7dc583 
>   src/CMakeLists.txt 0a50c54 
>   src/datastore.h a1276a7 
>   src/datastore.cpp 616e0cc 
>   src/mainwindow.h 1f059f8 
>   src/mainwindow.cpp 9d6e010 
>   src/plotseditor.cpp 106cdf5 
> 
> Diff: http://git.reviewboard.kde.org/r/110414/diff/
> 
> 
> Testing
> -------
> 
> Done..! worked perfect for any situtation I have come across. !
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130513/1a7baa53/attachment.html>