Review Request 109702: Fixed the bug of 3D plotting in Khipu

[Punit Mehta]

> On March 27, 2013, 8:48 p.m., Percy Camilo Triveño Aucahuasi wrote:
> > Hi Punit, 
> > 
> > I get this:
> > error: patch failed: src/plotseditor.cpp:705
> > 
> > However I saw your changes and I don't think you have to change the condition of those flags: you just add a new plot if you are not editing. 
> > 
> > Percy
> >

Hi Percy ,
>I get this:
>error: patch failed: src/plotseditor.cpp:705   
  May be there is some problem in the patch file ..:) I have attached the new diff file.
>However I saw your changes and I don't think you have to change the condition of those flags: you just add a new plot if you are not editing. 
           Yes, that is the thing. The code in the master branch checks it with the wrong condition in the if statement.


- Punit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109702/#review29968
-----------------------------------------------------------


On March 25, 2013, 7:05 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109702/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 7:05 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Fixed the bug of 3D function plotting. Khipu can plot the 3D surfaces in cartesian co-ordinate system.
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/109702/diff/
> 
> 
> Testing
> -------
> 
> Tested and Verfied on Kubuntu 12.10
> The results are coming as expected.
> 
> 
> File Attachments
> ----------------
> 
> Diff file
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/25/plotseditor_cpp.diff
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130328/eb18e816/attachment.html>