Review Request 109189: [Kig] Merge nowarnings Branch into master

[David Narváez]

> On Feb. 28, 2013, 11:10 p.m., Albert Astals Cid wrote:
> > filters/latexexporteroptions.cc, line 53
> > <http://git.reviewboard.kde.org/r/109189/diff/1/?file=116088#file116088line53>
> >
> >     personally i don't like this, can you implement all the cases instead of adding a default? This way when there are new enums we will get a warning instead of being catched by the default:

Good point, I'll implement the missing case


> On Feb. 28, 2013, 11:10 p.m., Albert Astals Cid wrote:
> > misc/special_constructors.cc, line 1590
> > <http://git.reviewboard.kde.org/r/109189/diff/1/?file=116094#file116094line1590>
> >
> >     personally i think that just commenting or removing the "os" parameter name is better, if you use Q_UNUSED if you start using "os" in the code later the Q_UNUSED will still be there and will look weird, if you comment or remove the param name you'll have to uncomment/add it so it will not be contradictory

I agree, will change this too.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109189/#review28309
-----------------------------------------------------------


On Feb. 27, 2013, 11:11 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109189/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 11:11 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> I started the nowarnings branch with the goal of eliminating all compilation branches in Kig. This will hopefully improve the perceived quality of the current code and help developers spot warnings when submitting new code.
> 
> This branch currently compiles without warnings in GCC 4.{6,7,8} and Clang 3.2. While most changes deal with the -Woverloaded-virtual warning in GCC, some changes are worth double  checking: kig.cpp, main.cpp and calcpaths.cc.
> 
> 
> Diffs
> -----
> 
>   filters/asyexporter.cc cbb872f1c3873019d6ca686cf75c7d1613be6a7c 
>   filters/asyexporterimpvisitor.h 630d0915d5211f525f37a8f1f546509ec4c61aef 
>   filters/cabri-filter.cc 411b450355981447f3e901551897968899e03396 
>   filters/latexexporter.cc 9edd34cc88eaf14b479007c4e2e8a1994e9656db 
>   filters/latexexporteroptions.cc be127827215f8539eebd615c94d09eef643638bc 
>   filters/pgfexporterimpvisitor.h 165f2df8ad9866fd1e43ae4160b90abcf2e74281 
>   filters/xfigexporter.cc 4c26cbff3a8f27b7a07570cb146c59895942c3f3 
>   kig/kig.cpp af1b9fe775f0115947cb427d3e6d115f88d7507c 
>   kig/main.cpp 94277a308cd83737ba63f803c6852204b05dd0b5 
>   misc/calcpaths.cc 4facd8fb797607fc1e8dc0f13752c98c92a78e9b 
>   misc/special_constructors.cc 23325bdca937b6947d73ccd80ae957c8f3f24346 
>   modes/base_mode.h e1365c6ebea58e3e010f19ba0a1118eb79970a9b 
>   modes/construct_mode.h ba069069a7ce62859a2eed43a8d9c4a9e3e78807 
>   modes/macro.h 2d58141c1a3c04877c41343fe24d7b3d10a17618 
>   modes/normal.h 1e11e6f67227eb4d9232470d080877bd9e1ec0e3 
>   objects/conic_types.h 849871f19d13c9b30209d72b3bffc9409cc3d769 
>   objects/line_type.h 5a95552edeb0e73aa13138d7815ed871a65d1347 
>   scripting/python_scripter.cc 7b882bda1b071533407cd880b93586fb2fb2cb92 
>   scripting/script_mode.h 4cbfd73763bef44061fe5a09c6254d95fa884a95 
> 
> Diff: http://git.reviewboard.kde.org/r/109189/diff/
> 
> 
> Testing
> -------
> 
> 1. Compiled and ran the application using GCC 4.6 (32 bits), GCC 4.{7,8} and Clang in (64 bits).
> 2. Compiled and ran with the --convert-to-native option
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130301/5d962d7a/attachment.html>