Review Request 111121: analitza fails to compile armhf due to qreal (float) and gldouble (double) type differences

[Maximiliano Curia]

> On June 19, 2013, 3:42 p.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotter3d.cpp, line 428
> > <http://git.reviewboard.kde.org/r/111121/diff/1/?file=164654#file164654line428>
> >
> >     Shouldn't we be using float on ARM here?
> >

Not really needed. But if you think it's better that way, you could use:
qreal matrix[16] = {0};
And then use the same trick than in glMultMatrix for glGetDoublev vs glGetFloatv (glGetModelMmatrix):
glGetModelMatrix(matrix);

Which is one of:
inline glGetModelMatrix(float *matrix) { glGetFloatv(GL_MODEL_MATRIX, matrix); }
inline glGetModelMatrix(double *matrix) { glGetDoublev(GL_MODEL_MATRIX, matrix); }


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111121/#review34683
-----------------------------------------------------------


On June 19, 2013, 3:33 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111121/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 3:33 p.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> .
> 
> 
> This addresses bug 321244.
>     http://bugs.kde.org/show_bug.cgi?id=321244
> 
> 
> Diffs
> -----
> 
>   analitzaplot/plotter3d.cpp 492a84c87558ce85722b0d26727f264a6d914e4c 
> 
> Diff: http://git.reviewboard.kde.org/r/111121/diff/
> 
> 
> Testing
> -------
> 
> .
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130619/bcb3ed8f/attachment.html>