Review Request 111051: Added a function to change the color of the reference plane's grids in plotter3D.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111051/#review34454
-----------------------------------------------------------



analitzaplot/plotter3d.h
<http://git.reviewboard.kde.org/r/111051/#comment25291>

    The name is not very clear. Also it misses documentation



analitzaplot/plotter3d.h
<http://git.reviewboard.kde.org/r/111051/#comment25292>

    m_refPlanecolor?
    
    You can put m_referencePlaneColor



analitzaplot/plotter3d.cpp
<http://git.reviewboard.kde.org/r/111051/#comment25293>

    Initialize with the rest of members, you can use QColor(r,g,b) constructor.
    
    Or even better, try with Qt::gray or Qt::lightgray.



analitzaplot/plotter3d.cpp
<http://git.reviewboard.kde.org/r/111051/#comment25294>

    You can do
    m_refPlanecolor = color.
    
    This is incorrect, and I'd expect from you to know that.


Also please remove the whitespace changes from the updated patch.

- Aleix Pol Gonzalez


On June 16, 2013, 6:15 p.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111051/
> -----------------------------------------------------------
> 
> (Updated June 16, 2013, 6:15 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> I have added a function in plotter3D class to change the color of the reference plane's grids. The color can be changed manually while using any application based on analitza.
> 
> Initially , it was only supporting  a "grey" color. Now , it can draw any color's grid based on the user's choice.
> 
> 
> Diffs
> -----
> 
>   analitzaplot/plotter3d.h 3b56226 
>   analitzaplot/plotter3d.cpp 492a84c 
> 
> Diff: http://git.reviewboard.kde.org/r/111051/diff/
> 
> 
> Testing
> -------
> 
> Done ! works perfect in khipu.
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130616/ddaeaaa2/attachment-0001.html>