Review Request 110992: Changed some code in plotsdictionarymodel.cpp and plotsdictionary.h to have better dictionary support

[Aleix Pol Gonzalez]

> On June 13, 2013, 11:50 p.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotsdictionarymodel.cpp, line 125
> > <http://git.reviewboard.kde.org/r/110992/diff/4/?file=150275#file150275line125>
> >
> >     Why do you emit the dimension?
> 
> Punit Mehta wrote:
>     The basic purpose for emitting the dimension is that when-ever , the 2D-plot is added to the model , we can know in the application that now we need to set the view to the PlotsView2D since the model contains the 2D plots and same for the 3D , too. 
>     Based on this , we can even make visible/invisible the PlotsView2D or PlotsView3D :)  So , it is just a trick I used :)

I don't like tricks :).

You can just use the item's dimension method PlotItem::spaceDimension().


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110992/#review34328
-----------------------------------------------------------


On June 14, 2013, 9:38 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110992/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 9:38 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Improvement in the code of plotsdictionarymodel class in analitzaplot.
> 
> 1) Initially , the constructor itself creates the dictionary. Now , the constructor just initializes the object and user/programmer can create the dictionary according to the wish and the flow of the program.
> 2) Also , I have added some improvements to support plotting from the dictionary for both the dimensions ( dim2D and dim3D ). For that , the assumption is that the dictionary file ( .plots file ) will contain the dimension in the first line as a comment ( e.g. [// dimension :=2 //] code in the first line in .plot file).
> 3) I have also added some other dictionary files ( for dim2D and dim3D )  so that other application based on Analitza ( in my case Khipu ) can use the dictionary support very well. These dictionary files are just for testing purpose. I am still looking forward in creating a rich collection of dictionary files. 
> Here, the dictionary files will be installed in the directory whose path will be like : [ default-kde-path / libanalitza /plots ].  
> 
> -> Once , the change will be merged in analitzaplot , khipu can also work very well as far as the dictionary support is concerned. :) 
> 
> 
> Diffs
> -----
> 
>   analitzaplot/data/plots/3Ds.plots PRE-CREATION 
>   analitzaplot/data/plots/basic_curves.plots 42d8ec7 
>   analitzaplot/data/plots/conics.plots PRE-CREATION 
>   analitzaplot/data/plots/polar.plots PRE-CREATION 
>   analitzaplot/plotsdictionarymodel.h a308cdc 
>   analitzaplot/plotsdictionarymodel.cpp 3e99167 
> 
> Diff: http://git.reviewboard.kde.org/r/110992/diff/
> 
> 
> Testing
> -------
> 
> Done.. works in khipu .. but I am not sure if other part of analitza uses plotsdictionarymodel. If that is the case , then we need to change the code for that class also . but as fas as I know , there is not any other class which depends on plotsdictionarymodel in analitza.
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130614/8e1a1dbe/attachment.html>