Review Request 110953: Stylistic changes to FindBoostPython.cmake and framework

[Vadim Zhukov]

> On June 11, 2013, 8:58 p.m., David Narváez wrote:
> > KigConfigureChecks.cmake, line 12
> > <http://git.reviewboard.kde.org/r/110953/diff/1/?file=149558#file149558line12>
> >
> >     What would you say about moving this and the macro_log_feature call below to CMakeLists.txt? I believe it is more visible there.

Personally I don't see any point in having KigConfigureChecks.cmake file at all. But this is probably for another patchset, to not complicate all current Kig reviews. Okay to post-pone this task?


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110953/#review34157
-----------------------------------------------------------


On June 11, 2013, 7:08 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110953/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 7:08 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Description
> -------
> 
> Polish FindBoostPython.cmake from CMake's point of view:
>   
>  * Use BoostPython_ prefix instead of BOOST_PYTHON_
>    (BOOSTPYTHON_ is also acceptable but is unreadable);
> 
>  * Remove extra call to find_package(BoostPython);
> 
>  * Replace macro_optional_find_package() with simple find_package(),
>    CMake has CMAKE_DISABLE_FIND_PACKAGE_Foo feature for a while.
> 
> This is a first patch of a bigger set, containing only minor fixes.
> 
> 
> This addresses bug 320807.
>     http://bugs.kde.org/show_bug.cgi?id=320807
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3c3da29 
>   KigConfigureChecks.cmake fed38b3 
>   cmake/modules/FindBoostPython.cmake d6c5a34 
> 
> Diff: http://git.reviewboard.kde.org/r/110953/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and 2.7.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130612/ca7cb058/attachment-0001.html>