Review Request 110953: Stylistic changes to FindBoostPython.cmake and framework
Vadim Zhukov
persgray at gmail.com
Tue Jun 11 15:08:14 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110953/
-----------------------------------------------------------
Review request for KDE Edu and David Narváez.
Description
-------
Polish FindBoostPython.cmake from CMake's point of view:
* Use BoostPython_ prefix instead of BOOST_PYTHON_
(BOOSTPYTHON_ is also acceptable but is unreadable);
* Remove extra call to find_package(BoostPython);
* Replace macro_optional_find_package() with simple find_package(),
CMake has CMAKE_DISABLE_FIND_PACKAGE_Foo feature for a while.
This is a first patch of a bigger set, containing only minor fixes.
This addresses bug 320807.
http://bugs.kde.org/show_bug.cgi?id=320807
Diffs
-----
CMakeLists.txt 3c3da29
KigConfigureChecks.cmake fed38b3
cmake/modules/FindBoostPython.cmake d6c5a34
Diff: http://git.reviewboard.kde.org/r/110953/diff/
Testing
-------
OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and 2.7.
Thanks,
Vadim Zhukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130611/ac63cb34/attachment.html>
More information about the kde-edu
mailing list