Review Request 110890: Asking confirmation while quitting parley.

Tarang Patel tarangrockr at gmail.com
Sat Jun 8 14:20:12 UTC 2013



> On June 8, 2013, 12:47 p.m., Peter Hedlund wrote:
> > What bug are you trying to fix? I don't see a bug number. In my opinion nothing is more annoying than being asked if I want to quit a program. If I choose Quit I want to quit.
> > 
> > Peter
> 
> Tarang Patel wrote:
>     Sorry, it is not in the bug list. It is in TODO file that ask when user quit parley.
> 
> Albert Astals Cid wrote:
>     Can you please upload the diff corrrectly and not as an attachment? (Hint: Update -> Upload diff)

Actually I did that. But it shows that specified diff file is empty. I tried many times. I don't know why it is showing that. So, I attached it.


- Tarang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110890/#review33940
-----------------------------------------------------------


On June 8, 2013, 2:15 p.m., Tarang Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110890/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 2:15 p.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Fixed bug of asking confirmation while quitting parley.
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/110890/diff/
> 
> 
> Testing
> -------
> 
> Tested and verified on Ubuntu 12.04 
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/08/patch.diff
> 
> 
> Thanks,
> 
> Tarang Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130608/2e32f4ae/attachment.html>


More information about the kde-edu mailing list