Review Request 111470: Allow loading google images plugin on non-ASCII locales

[Yuri Chornoivan]

> On July 21, 2013, 3:58 p.m., Albert Astals Cid wrote:
> > plugins/google_images.py, line 250
> > <http://git.reviewboard.kde.org/r/111470/diff/1/?file=169754#file169754line250>
> >
> >     I'm not much into python, but seems to me that instead of adding the toUtf8 it'd be simpler to remove the str() (if that works of course :D)

No. This does not work:

/usr/share/apps/parley/plugins/google_images.py, ????? 250:
Setting attribute "statusTip" failed.
Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
action1.statusTip = i18n("Fetches an image for the selected translation")


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111470/#review36254
-----------------------------------------------------------


On July 10, 2013, 6:11 a.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111470/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 6:11 a.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message:
> 
> /usr/share/apps/parley/plugins/google_images.py, line 250:
> 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
> Backtrace:
> File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
> action1.statusTip = str(i18n("Fetches an image for the selected translation"))
> 
> This patch tries to avoid this inconvenience.
> 
> 
> Diffs
> -----
> 
>   plugins/google_images.py 5317ba6 
> 
> Diff: http://git.reviewboard.kde.org/r/111470/diff/
> 
> 
> Testing
> -------
> 
> No errors while loading editor. Plugin does not work anyway, but it's a different story. ;)
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130721/73ca765a/attachment.html>