Review Request 110890: Asking confirmation while quitting parley.

Albert Astals Cid aacid at kde.org
Sun Jul 21 15:40:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110890/#review36252
-----------------------------------------------------------



parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/110890/#comment26818>

    Remove the extra space you added



parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/110890/#comment26819>

    Why Yes/No/Cancel?
    
    Why the extra \n?


- Albert Astals Cid


On June 8, 2013, 4:03 p.m., Tarang Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110890/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 4:03 p.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Fixed bug of asking confirmation while quitting parley.
> 
> 
> Diffs
> -----
> 
>   parleymainwindow.cpp e3acb66 
> 
> Diff: http://git.reviewboard.kde.org/r/110890/diff/
> 
> 
> Testing
> -------
> 
> Tested and verified on Ubuntu 12.04 
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/08/patch.diff
> 
> 
> Thanks,
> 
> Tarang Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130721/39b0f19b/attachment.html>


More information about the kde-edu mailing list