Review Request 111472: Used KIO for opening and saving a file in Khipu

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111472/#review35836
-----------------------------------------------------------



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26514>

    Don't add a space before the "?".



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26509>

    You should define the variables where you use them.
    
    for(int i=0...



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26510>

    Why do you iterate using an int then access it?
    
    foreach(DictionaryItem* space, spaceList) {...



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26494>

    You're leaking QFile. Please put it in the stack.
    
    Also prefer ::toLocalFile rather than ::path.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26500>

    use i18n()



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26498>

    fix indentation


- Aleix Pol Gonzalez


On July 10, 2013, 10:32 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111472/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 10:32 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Used KIO for saving and opening a file in khipu. I have already reviewed this diff with Antonio. But still , I think it is better to publish it once !
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 027da30 
>   src/mainwindow.h 137e82c 
>   src/mainwindow.cpp 67d8c72 
> 
> Diff: http://git.reviewboard.kde.org/r/111472/diff/
> 
> 
> Testing
> -------
> 
> done ! worked perfectly ! 
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130710/13296343/attachment-0001.html>