Review Request 108594: Improved the derivative transformations in analitza/providederivative.cpp

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108594/#review26228
-----------------------------------------------------------


Hi Heena!
It's really interesting work. Please make sure that you're aware of the code in the analyzer.cpp side.

Also provide unit tests and use them to make sure you're providing useful features.


analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19959>

    That's not correct, this generalization only works in case n is a Real number, which is already covered somewhere else.



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19960>

    That's equivalent, IIRC. Why do you change it?



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19963>

    It's cool that you added those. Can you add unit testing?



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19962>

    This is quite redundant. We know the derivative of division and we know cos(). Why do you add the derivative of 1/cos()?



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19961>

    don't leave commented code, it's not very helpful in the future



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19964>

    We don't have a loga() operation. What is this?



analitza/providederivative.cpp
<http://git.reviewboard.kde.org/r/108594/#comment19965>

    Those cases are already covered in the analyzer side.


- Aleix Pol Gonzalez


On Jan. 26, 2013, 12:29 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108594/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 12:29 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> added some transformations in providederivative.cpp
> 
> 
> Diffs
> -----
> 
>   analitza/providederivative.cpp 0591c06 
> 
> Diff: http://git.reviewboard.kde.org/r/108594/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130127/e2e064d4/attachment.html>