Review Request 108592: Added some more operations in analitza

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108592/#review26227
-----------------------------------------------------------



analitza/operations.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19949>

    Why did you do that?



analitza/operations.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19950>

    Fix indentation.
    Also we don't usually add copyright there...



analitza/operations.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19951>

    Fix indentation.
    That doesn't even compile... Have you tried it?
    Also those a,b= definitions are not correct, please check the semantics.



analitza/operations.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19952>

    We don't have a type for imaginary values yet, you can't just decide that an imaginary value is a value just like that.



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19953>

    You can just put the result, it's ok



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19945>

    Here you're not testing correctly. Why do you pass it as a lambda?
    
    Just test remainder.



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19954>

    That's not needed, here you're checking lambda calculations with a remainder inside, there's no reason to create such a test case.
    
    Or?



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19955>

    This hasn't even been implemented, I think it's ok not to have this translation, but never add test cases that don't pass as something ready. It doesn't make sense.



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19946>

    don't test that, here you should add tests for remainder, not remainder being used by the rest of features in the language.



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19956>

    Same as before, here you're testing the passing variables to an operation, different feature being tested



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19948>

    same



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19957>

    same, why do you try to call a remainder within an operation. There's no difference between remainder and plus



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19947>

    same



analitza/tests/analitzatest.cpp
<http://git.reviewboard.kde.org/r/108592/#comment19958>

    same


- Aleix Pol Gonzalez


On Jan. 26, 2013, 12:29 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108592/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 12:29 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> I added a few logic gates operations like xnor,nor ,log function lg(base 2),and complex functions -real,imaginary,conjugate,argument.
> 
> 
> Diffs
> -----
> 
>   analitza/operations.cpp 37b9820 
>   analitza/operator.h dd7a93e 
>   analitza/operator.cpp 4e5535b 
>   analitza/tests/analitzatest.cpp f41aaf1 
> 
> Diff: http://git.reviewboard.kde.org/r/108592/diff/
> 
> 
> Testing
> -------
> 
> I am not sure about the complex functions rest seems fine I guess :p(Though compiled successfully)
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130127/9c7a65fb/attachment-0001.html>