Review Request 108531: Make glossar messages with XML Unicode entities (e.g. ± ) translatable

Albert Astals Cid aacid at kde.org
Mon Jan 21 21:04:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108531/#review25924
-----------------------------------------------------------

Ship it!


This happens because QDomDocument does the entity->text conversion automatically, so when the text is passed to i18n the entity is not there anymore and thus can't match the extracted text. So this makes sense :-)

Good find!

- Albert Astals Cid


On Jan. 21, 2013, 7:37 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108531/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 7:37 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Description
> -------
> 
> some glossar messages with XML Unicode entities are untranslatable, 
> patch by Stefan Asserhall, bug reporter
> 
> 
> This addresses bug 281498.
>     http://bugs.kde.org/show_bug.cgi?id=281498
> 
> 
> Diffs
> -----
> 
>   data/knowledge.xml cafce4a 
> 
> Diff: http://git.reviewboard.kde.org/r/108531/diff/
> 
> 
> Testing
> -------
> 
> applied, changed catalog accordingly and installed it, all messages in glossar are translated now
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130121/7f54b437/attachment.html>


More information about the kde-edu mailing list