Review Request: KStars: fixed code checker issues #2

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108192/#review24757
-----------------------------------------------------------


Very good, almost ready for "ship it"


kstars/printing/pwizfovsh.cpp
<http://git.reviewboard.kde.org/r/108192/#comment19034>

    also just
    detailDlg->exec();



kstars/printing/pwizobjectselection.cpp
<http://git.reviewboard.kde.org/r/108192/#comment19035>

    also just
    detailDlg->exec();



kstars/printing/pwizprint.cpp
<http://git.reviewboard.kde.org/r/108192/#comment19036>

    also just
    previewDlg->exec();


- Kevin Krammer


On Jan. 5, 2013, 3:24 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108192/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 3:24 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8192207
> 
> 
> Diffs
> -----
> 
>   kstars/ekos/guide/gmath.cpp bf629a2 
>   kstars/ekos/guide/guider.cpp 30c6bcd 
>   kstars/ekos/guide/rcalibration.cpp 3340ae4 
>   kstars/ekos/guide/scroll_graph.cpp a37e81c 
>   kstars/kstarsactions.cpp 185507a 
>   kstars/printing/pwizfovbrowse.cpp 94edd09 
>   kstars/printing/pwizfovsh.cpp b5a4101 
>   kstars/printing/pwizobjectselection.cpp 50b9f5a 
>   kstars/printing/pwizprint.cpp 5c95318 
>   kstars/skyobjects/satellite.cpp 0ca44f7 
>   kstars/tools/conjunctions.cpp 6b8c081 
>   kstars/tools/modcalcvlsr.cpp 2a9b355 
> 
> Diff: http://git.reviewboard.kde.org/r/108192/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130105/ea87d7c2/attachment.html>