Review Request: Fix Kstars Code: Explicit constructors #2

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108175/#review24747
-----------------------------------------------------------

Ship it!


Not sure how this built for Akarsh but I had to revert the explicits in KStarsDateTime since those constructors are needed for implicit conversions.
The KStars developers will have to check whether they want them replaced by explicit conversions or tell krazy to exclude them

- Kevin Krammer


On Jan. 5, 2013, 7:50 a.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108175/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 7:50 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Fix Kstars Code: Explicit constructors
> 
> 
> Diffs
> -----
> 
>   kstars/kstarsdatetime.h 87059aa 
>   kstars/printing/foveditordialog.h 65e0695 
>   kstars/printing/legend.h 4861f0d 
>   kstars/printing/printingwizard.h 6d5f3e3 
>   kstars/printing/pwizchartconfig.h 551562d 
>   kstars/printing/pwizchartcontents.h 0f68dc1 
>   kstars/printing/pwizfovbrowse.h 2828f74 
>   kstars/printing/pwizfovconfig.h 6bb3cc2 
>   kstars/printing/pwizfovmanual.h 5aa1d96 
>   kstars/printing/pwizfovsh.h 0783b93 
>   kstars/printing/pwizfovtypeselection.h d2d235a 
>   kstars/printing/pwizobjectselection.h 421dfeb 
>   kstars/printing/pwizprint.h d16c4ad 
>   kstars/projections/azimuthalequidistantprojector.h 40ff9df 
>   kstars/projections/gnomonicprojector.h dd4f689 
>   kstars/projections/lambertprojector.h d08f9b2 
>   kstars/skycomponents/targetlistcomponent.h 04140a8 
>   kstars/skyglpainter.h b45c11a 
>   kstars/skymapdrawabstract.h 0d690ef 
>   kstars/skymapqdraw.h 1e92951 
>   kstars/targetlistcomponent.h 04140a8 
>   kstars/texturemanager.h 73f8a86 
>   kstars/widgets/fovwidget.h ac2166a 
>   kstars/widgets/genericcalendarwidget.h 7bb6ee8 
>   kstars/widgets/infoboxwidget.h 7defae5 
>   kstars/widgets/kshelplabel.h 62cf607 
>   kstars/widgets/logedit.h af1f8b7 
>   kstars/widgets/mapcanvas.h 9b58f97 
>   kstars/widgets/moonphasecalendarwidget.h 99e83a7 
> 
> Diff: http://git.reviewboard.kde.org/r/108175/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130105/604e06bf/attachment.html>