Review Request: Fix Kstars Code: Explicit constructors

Kevin Krammer krammer at kde.org
Fri Jan 4 20:23:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108171/#review24702
-----------------------------------------------------------


looks very good, I'll check integration.
btw, the description should be more like
"mark constructors as explicit that could be used for implicit type conversions" :)

- Kevin Krammer


On Jan. 4, 2013, 8:17 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108171/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 8:17 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Made required constructors explicit to allow specified type conversions.
> 
> 
> Diffs
> -----
> 
>   kstars/dialogs/addcatdialog.h 99298bc 
>   kstars/dialogs/addlinkdialog.h 0119066 
>   kstars/dialogs/detaildialog.h d98cc1b 
>   kstars/dialogs/finddialog.h 8471672 
>   kstars/dialogs/focusdialog.h 64f2603 
>   kstars/dialogs/fovdialog.h 54c45b5 
>   kstars/dialogs/locationdialog.h bb4a6f8 
>   kstars/ekos/QProgressIndicator.h 0614da6 
>   kstars/ekos/guide/guider.h baa79bc 
>   kstars/ekos/guide/matr.h 0612dff 
>   kstars/ekos/guide/rcalibration.h 268a49e 
>   kstars/ekos/guide/vect.h 89c31e6 
>   kstars/ekos/opsekos.h a021faf 
>   kstars/imageviewer.h 4466109 
>   kstars/ksfilereader.h 63557f6 
>   kstars/skyqpainter.h 4a2b5d2 
>   kstars/thumbnaileditor.h 01d3c78 
>   kstars/thumbnailpicker.h 71ce346 
>   kstars/widgets/magnitudespinbox.h a53e6dd 
>   kstars/xplanet/opsxplanet.h d4a4b0c 
> 
> Diff: http://git.reviewboard.kde.org/r/108171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130104/331127f3/attachment-0001.html>


More information about the kde-edu mailing list