Review Request: KStars: fixed code checker issues #1

[Akarsh Simha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108166/#review24683
-----------------------------------------------------------


Please see my note about MAKE_KSTARS_SLOW before shipping it.

I'll also request my colleague who wrote that code to check if that's okay.


kstars/ekos/guide/matr.cpp
<http://git.reviewboard.kde.org/r/108166/#comment18931>

    Shouldn't math.h go below vect.h?
    



kstars/skyglpainter.cpp
<http://git.reviewboard.kde.org/r/108166/#comment18930>

    After making this change, check that there are no issues with clipping of the sky polygons, and things like the Milky Way, horizon appear perfectly without problems in all projections.
    
    This might be introducing a bug. It is better not to assume that polygons are convex, although it does add some overhead in processing. MAKE_KSTARS_SLOW might make KStars a bit slow, but it might also fix a lot of bugs that we have to otherwise deal with.
    
    If you're unsure, I do not recommend making this change.


- Akarsh Simha


On Jan. 4, 2013, 5:44 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108166/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:44 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8203202
> 
> 
> Diffs
> -----
> 
>   Tests/CMakeLists.txt dfaa9d9 
>   Tests/testfwparser.cpp fc7e83a 
>   datahandlers/CMakeLists.txt a2d3207 
>   kstars/ekos/capture.cpp 59f203b 
>   kstars/ekos/ekosmanager.cpp 18b8b29 
>   kstars/ekos/guide.cpp 0aca5e9 
>   kstars/ekos/guide/common.cpp c3a7c08 
>   kstars/ekos/guide/gmath.cpp 042add9 
>   kstars/ekos/guide/guider.cpp aa85171 
>   kstars/ekos/guide/matr.cpp 25b6b68 
>   kstars/ekos/guide/rcalibration.h 268a49e 
>   kstars/ekos/guide/rcalibration.cpp 3787768 
>   kstars/ekos/guide/vect.cpp 9df115a 
>   kstars/fitsviewer/fitsviewer.cpp 33c2079 
>   kstars/oal/scope.cpp 819bdc0 
>   kstars/options/opssupernovae.cpp 970f116 
>   kstars/printing/legend.cpp 2eddd3c 
>   kstars/printing/printingwizard.cpp cd75b58 
>   kstars/skycomponents/asteroidscomponent.cpp b590dfb 
>   kstars/skycomponents/satellitescomponent.cpp 6585d07 
>   kstars/skycomponents/supernovaecomponent.h f2af09b 
>   kstars/skycomponents/supernovaecomponent.cpp 1c5a34d 
>   kstars/skyglpainter.cpp 22ae124 
>   kstars/skymapqdraw.cpp a495634 
>   kstars/skyobjects/satellite.cpp 770439f 
> 
> Diff: http://git.reviewboard.kde.org/r/108166/diff/
> 
> 
> Testing
> -------
> 
> built and tested
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130104/13a3c7cb/attachment.html>