Review Request: Normalizing SIGNAL and SLOT signatures

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108094/#review24665
-----------------------------------------------------------

Ship it!


I fixed the build errors before committing.

In two instances they were caused by explicit on "upgrade" constructors, i.e. a subclass being initialzed through an instance of a base class. e.g. GeoDataLinearRing being initialized with a GeoDataLineString instance.
I've reverted the explicits for those cases, someone from Marble's developer team needs to check if those convertions are wanted and if yes mark the line with a krazy exclude.

Another cause was a missing include in a file that got QtCore module include replaced by individual includes. Fixed by adding the missing include.

- Kevin Krammer


On Jan. 3, 2013, 6:24 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108094/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 6:24 p.m.)
> 
> 
> Review request for KDE Edu, Kevin Krammer and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Fixing SIGNAL/SLOT signatures to normalized form as reported by Krazy
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 14f20dc 
>   src/lib/TileCoordsPyramid.h b669e6c 
>   src/lib/geodata/data/GeoDataContainer.h 8cb94cb 
>   src/lib/geodata/data/GeoDataLatLonAltBox.h 7276842 
>   src/lib/geodata/data/GeoDataLineString.h 1f833d0 
>   src/lib/geodata/data/GeoDataLinearRing.h 9cfce6d 
>   src/lib/geodata/data/GeoDataMultiGeometry.h 00f775f 
>   src/lib/geodata/data/GeoDataMultiTrack.h d929da8 
>   src/lib/geodata/data/GeoDataPlacemark.h 5dcfe6a 
>   src/lib/geodata/data/GeoDataPoint.h 2e8df39 
>   src/lib/geodata/data/GeoDataPolygon.h 788f19e 
>   src/lib/geodata/data/GeoDataTrack.h 98d8819 
>   src/plugins/declarative/Bookmarks.cpp 4319aab 
>   src/plugins/declarative/DeclarativeDataPlugin.cpp 8cd54f9 
>   src/plugins/declarative/MapThemeModel.cpp 47bc226 
>   src/plugins/declarative/Navigation.cpp 8636101 
>   src/plugins/declarative/OfflineDataModel.cpp 181319a 
>   src/plugins/declarative/PositionSource.cpp 03bb401 
>   src/plugins/declarative/RouteRequestModel.cpp aae7ff1 
>   src/plugins/declarative/Routing.cpp 7147d47 
>   src/plugins/declarative/Search.cpp 5bf98e2 
>   src/plugins/render/navigation/ArrowDiscWidget.h ad88852 
>   src/plugins/render/satellites/SatellitesMSCItem.cpp 465d1b9 
>   src/plugins/render/satellites/TrackerPluginItem.h c88e1ef 
>   src/plugins/render/twitter/twitterPlugin.cpp 81cbc30 
>   src/plugins/render/weather/BBCParser.h e1ca1e5 
>   src/plugins/runner/json/JsonParser.h 947f7df 
>   src/plugins/runner/json/JsonParser.cpp fc5eadf 
>   src/plugins/runner/local-osm-search/DatabaseQuery.h 0f8809d 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp 12d027e 
>   src/plugins/runner/osm/handlers/OsmNodeFactory.h 25d17ad 
>   src/plugins/runner/osm/handlers/OsmNodeFactory.cpp df25c95 
>   src/plugins/runner/osm/handlers/OsmRelationFactory.h a4c5f61 
>   src/plugins/runner/osm/handlers/OsmRelationFactory.cpp f1e9fdc 
>   src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 892df17 
>   src/plugins/runner/osm/handlers/OsmWayFactory.h d3f3126 
>   src/plugins/runner/osm/handlers/OsmWayFactory.cpp a709ae5 
>   src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp 1fc753c 
>   src/plugins/runner/pn2/Pn2Runner.cpp 767911f 
> 
> Diff: http://git.reviewboard.kde.org/r/108094/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130104/17c889ef/attachment.html>