Review Request: Normalizing SIGNAL and SLOT signatures

Torsten Rahn tackat at kde.org
Thu Jan 3 00:32:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108094/#review24538
-----------------------------------------------------------


I'm sorry, but "spacing fixes" and other pure code formatting styling are not accepted as fixes. This is something that doesn't qualify for the minimum amount of creativity required for task completion. 

- Torsten Rahn


On Jan. 2, 2013, 9:03 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108094/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 9:03 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Fixing SIGNAL/SLOT signatures to normalized form as reported by Krazy
> 
> 
> Diffs
> -----
> 
>   src/plugins/declarative/Bookmarks.cpp 4319aab 
>   src/plugins/declarative/DeclarativeDataPlugin.cpp 8cd54f9 
>   src/plugins/declarative/MapThemeModel.cpp 47bc226 
>   src/plugins/declarative/Navigation.cpp 8636101 
>   src/plugins/declarative/OfflineDataModel.cpp 181319a 
>   src/plugins/declarative/PositionSource.cpp 03bb401 
>   src/plugins/declarative/RouteRequestModel.cpp aae7ff1 
>   src/plugins/declarative/Routing.cpp 7147d47 
>   src/plugins/declarative/Search.cpp 5bf98e2 
>   src/plugins/render/twitter/twitterPlugin.cpp 81cbc30 
> 
> Diff: http://git.reviewboard.kde.org/r/108094/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130103/b522ee5d/attachment.html>


More information about the kde-edu mailing list