Review Request: Krazy fixes: mark single argument constructors as explicit #1

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108069/#review24383
-----------------------------------------------------------


IMO, krazy should not warn in such cases. It seems to be an old habit in projects here and there not to use explicit for such cases when the argument is only the parent qobject (for understandable reason in my opinion).

- Laszlo Papp


On Jan. 1, 2013, 7:19 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108069/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 7:19 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Add explicit keyword to constructors which could potentially lead to implicit type conversions
> 
> 
> Diffs
> -----
> 
>   src/plugins/declarative/OfflineDataModel.h 2f2ddcb 
>   src/plugins/declarative/Placemark.h dc383b3 
>   src/plugins/positionprovider/geoclue/GeoCute/MasterClient.h 893cce0 
>   src/plugins/positionprovider/gpsd/GpsdConnection.h f266996 
>   src/plugins/render/aprs/AprsFile.h 96fb4fa 
>   src/plugins/render/aprs/AprsSource.h 372cf31 
>   src/plugins/render/aprs/AprsTTY.h baff58e 
>   src/plugins/render/crosshairs/CrosshairsPlugin.h 061555b 
>   src/plugins/render/earthquake/EarthquakeItem.h 85c13f8 
>   src/plugins/render/opendesktop/OpenDesktopItem.h bf901f7 
>   src/plugins/render/osmannotate/osm/OsmBoundsGraphicsItem.h 5437835 
>   src/plugins/render/panoramio/PanoramioModel.h 1b18f32 
>   src/plugins/render/panoramio/PanoramioWidget.h cddc372 
>   src/plugins/render/photo/CoordinatesParser.h ee7cc2f 
>   src/plugins/render/postalcode/PostalCodeItem.h 020703e 
>   src/plugins/render/satellites/SatellitesConfigDialog.h 64f9809 
>   src/plugins/render/satellites/TrackerPluginItem.h f224981 
>   src/plugins/render/satellites/mex/attlib.h 4b06be3 
>   src/plugins/render/weather/BBCItemGetter.h 0b5c6f1 
>   src/plugins/render/weather/BBCWeatherItem.h b7f1536 
>   src/plugins/render/weather/BBCWeatherService.h c0a4324 
>   src/plugins/render/weather/FakeWeatherItem.h a057804 
>   src/plugins/render/weather/FakeWeatherService.h 73c786c 
>   src/plugins/render/weather/GeoNamesWeatherItem.h 597b139 
>   src/plugins/render/weather/GeoNamesWeatherService.h 007a28d 
>   src/plugins/render/weather/StationListParser.h ac04137 
>   src/plugins/render/weather/WeatherItem.h 2b88905 
>   src/plugins/runner/latlon/LatLonRunner.h 1ea8e67 
>   src/plugins/runner/localdatabase/LocalDatabaseRunner.h 5341a02 
> 
> Diff: http://git.reviewboard.kde.org/r/108069/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130101/02022d7a/attachment.html>